lint

.rubocop.yml

@@ -1,9 +1,15 @@
-require: rubocop-rspec
+require:
+  - rubocop-performance
+  - rubocop-rspec
 
 inherit_from: .rubocop_todo.yml
 
-Rails:
+Layout/AlignArguments:
-  Enabled: true
+  EnforcedStyle: with_fixed_indentation
+
+Layout/AlignHash:
+  EnforcedColonStyle: table
+  Enabled: false
 
 Layout/AlignParameters:
   EnforcedStyle: with_fixed_indentation
@@ -11,14 +17,32 @@ Layout/AlignParameters:
 Layout/EmptyLinesAroundArguments:
   Enabled: false
 
-Rails/ApplicationRecord:
+Layout/MultilineMethodCallBraceLayout:
+  EnforcedStyle: new_line
+
+Metrics/AbcSize:
+  Max: 50
+
+Metrics/BlockLength:
   Enabled: false
 
-RSpec/DescribeMethod:
+Metrics/LineLength:
+  Max: 120
+
+Metrics/MethodLength:
+  Max: 50
+
+Naming/VariableNumber:
+  EnforcedStyle: snake_case
+
+Rails:
+  Enabled: true
+
+RSpec/AnyInstance:
   Enabled: false
 
 RSpec/ExampleLength:
-  Max: 10
+  Enabled: false
 
 RSpec/FilePath:
   Enabled: false
@@ -29,12 +53,6 @@ RSpec/MultipleExpectations:
 RSpec/NestedGroups:
   Max: 5
 
-Metrics/LineLength:
-  Max: 120
-
-Naming/VariableNumber:
-  EnforcedStyle: snake_case
-
 Style/Documentation:
   Enabled: false
 
@@ -46,3 +64,12 @@ Style/PercentLiteralDelimiters:
     '%r': '()'
     '%w': '[]'
     '%W': '[]'
+
+Style/PerlBackrefs:
+  Enabled: false
+
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInHashLiteral:
+  EnforcedStyleForMultiline: comma

lib/generators/rating/install_generator.rb

@@ -2,7 +2,7 @@
 
 module Rating
   class InstallGenerator < Rails::Generators::Base
-    source_root File.expand_path('../templates', __FILE__)
+    source_root File.expand_path('templates', __dir__)
 
     desc 'Creates Rating migration'
 

lib/rating/config.rb

@@ -29,8 +29,8 @@ module Rating
         {
           rate: {
             case_sensitive: config.dig('validations', 'rate', 'case_sensitive') || false,
-            scope:          config.dig('validations', 'rate', 'scope') || default_scope
+            scope:          config.dig('validations', 'rate', 'scope') || default_scope,
-          }
+          },
         }.deep_stringify_keys
       end
     end

lib/rating/models/rating/extension.rb

@@ -73,7 +73,7 @@ module Rating
           class_name: '::Rating::Rate',
           dependent:  :destroy
 
-        scope :order_by_rating, ->(column = :estimate, direction = :desc, scope: nil) {
+        scope :order_by_rating, lambda { |column = :estimate, direction = :desc, scope: nil|
           includes(:rating_records)
             .where(Rating.table_name => { scopeable_id: scope&.id, scopeable_type: scope&.class&.base_class&.name })
             .order("#{Rating.table_name}.#{column} #{direction}")

lib/rating/models/rating/rate.rb

@@ -16,7 +16,7 @@ module Rating
 
     validates :author_id, uniqueness: {
       case_sensitive: ::Rating::Config.validations['rate']['case_sensitive'],
-      scope:          ::Rating::Config.validations['rate']['scope'].map(&:to_sym)
+      scope:          ::Rating::Config.validations['rate']['scope'].map(&:to_sym),
     }
 
     def self.create(author:, extra_scopes:, metadata:, resource:, scopeable: nil, value:)

lib/rating/models/rating/rating.rb

@@ -13,7 +13,7 @@ module Rating
 
     validates :resource_id, uniqueness: {
       case_sensitive: false,
-      scope:          %i[resource_type scopeable_id scopeable_type]
+      scope:          %i[resource_type scopeable_id scopeable_type],
     }
 
     class << self
@@ -43,7 +43,7 @@ module Rating
           average:  values.rating_avg,
           estimate: estimate(averager, values),
           sum:      values.rating_sum,
-          total:    values.rating_count
+          total:    values.rating_count,
         }
       end
 

rating.gemspec

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 

spec/config/rate_table_spec.rb

@@ -3,11 +3,15 @@
 require 'rails_helper'
 
 RSpec.describe Rating::Config, '.rate_table' do
+  if ENV['CONFIG_ENABLED'] != 'true'
     context 'when rating.yml does not exist' do
       it { expect(subject.rate_table).to eq 'rating_rates' }
-  end if ENV['CONFIG_ENABLED'] != 'true'
+    end
+  end
 
+  if ENV['CONFIG_ENABLED'] == 'true'
     context 'when rating.yml exists' do
       it { expect(subject.rate_table).to eq 'reviews' }
-  end if ENV['CONFIG_ENABLED'] == 'true'
+    end
+  end
 end

spec/config/rating_table_spec.rb

@@ -3,11 +3,15 @@
 require 'rails_helper'
 
 RSpec.describe Rating::Config, '.rating_table' do
+  if ENV['CONFIG_ENABLED'] != 'true'
     context 'when rating.yml does not exist' do
       it { expect(subject.rating_table).to eq 'rating_ratings' }
-  end if ENV['CONFIG_ENABLED'] != 'true'
+    end
+  end
 
+  if ENV['CONFIG_ENABLED'] == 'true'
     context 'when rating.yml exists' do
       it { expect(subject.rating_table).to eq 'review_ratings' }
-  end if ENV['CONFIG_ENABLED'] == 'true'
+    end
+  end
 end

spec/config/validations_spec.rb

@@ -3,25 +3,31 @@
 require 'rails_helper'
 
 RSpec.describe Rating::Config, '.validations' do
+  if ENV['CONFIG_ENABLED_WITH_EXTRA_SCOPES'] != 'true'
     context 'when rating.yml does not exist' do
       it do
         expect(subject.validations).to eq({
           rate: {
             case_sensitive: false,
-          scope:          %w[author_type resource_id resource_type scopeable_id scopeable_type]
+            scope:          %w[author_type resource_id resource_type scopeable_id scopeable_type],
-        }
+          },
-      }.deep_stringify_keys)
+        }.deep_stringify_keys
+                                         )
+      end
+    end
   end
-  end if ENV['CONFIG_ENABLED_WITH_EXTRA_SCOPES'] != 'true'
 
+  if ENV['CONFIG_ENABLED_WITH_EXTRA_SCOPES'] == 'true'
     context 'when rating.yml exists' do
       it do
         expect(subject.validations).to eq({
           rate: {
             case_sensitive: false,
-          scope:          %w[author_type resource_id resource_type scopeable_id scopeable_type scope_1 scope_2]
+            scope:          %w[author_type resource_id resource_type scopeable_id scopeable_type scope_1 scope_2],
-        }
+          },
-      }.deep_stringify_keys)
+        }.deep_stringify_keys
+                                         )
+      end
+    end
   end
-  end if ENV['CONFIG_ENABLED_WITH_EXTRA_SCOPES'] == 'true'
 end

spec/factories/rating/rate.rb

@@ -2,7 +2,7 @@
 
 FactoryBot.define do
   factory :rating_rate, class: Rating::Rate do
-    value 100
+    value { 100 }
 
     author   { create :author }
     resource { create :article }

spec/factories/rating/rating.rb

@@ -2,10 +2,10 @@
 
 FactoryBot.define do
   factory :rating_rating, class: Rating::Rating do
-    average  100
+    average  { 100 }
-    estimate 100
+    estimate { 100 }
-    sum      100
+    sum      { 100 }
-    total    1
+    total    { 1 }
 
     association :resource, factory: :article, strategy: :build
   end

spec/models/extension/order_by_rating_spec.rb

@@ -11,7 +11,7 @@ RSpec.describe Rating::Extension, ':order_by_rating' do
       expect(Article.order_by_rating).to eq [
         article_1,
         article_2,
-        article_3
+        article_3,
       ]
     end
   end
@@ -22,14 +22,14 @@ RSpec.describe Rating::Extension, ':order_by_rating' do
         expect(Article.order_by_rating(:average, :asc)).to eq [
           article_3,
           article_2,
-          article_1
+          article_1,
         ]
       end
 
       context 'with scope' do
         it 'works' do
           expect(Article.order_by_rating(:average, :asc, scope: category)).to eq [
-            article_1
+            article_1,
           ]
         end
       end
@@ -40,14 +40,14 @@ RSpec.describe Rating::Extension, ':order_by_rating' do
         expect(Article.order_by_rating(:average, :desc)).to eq [
           article_1,
           article_2,
-          article_3
+          article_3,
         ]
       end
 
       context 'with scope' do
         it 'works' do
           expect(Article.order_by_rating(:average, :desc, scope: category)).to eq [
-            article_1
+            article_1,
           ]
         end
       end
@@ -60,14 +60,14 @@ RSpec.describe Rating::Extension, ':order_by_rating' do
         expect(Article.order_by_rating(:estimate, :asc)).to eq [
           article_3,
           article_2,
-          article_1
+          article_1,
         ]
       end
 
       context 'with scope' do
         it 'works' do
           expect(Article.order_by_rating(:estimate, :asc, scope: category)).to eq [
-            article_1
+            article_1,
           ]
         end
       end
@@ -78,14 +78,14 @@ RSpec.describe Rating::Extension, ':order_by_rating' do
         expect(Article.order_by_rating(:estimate, :desc)).to eq [
           article_1,
           article_2,
-          article_3
+          article_3,
         ]
       end
 
       context 'with scope' do
         it 'works' do
           expect(Article.order_by_rating(:estimate, :desc, scope: category)).to eq [
-            article_1
+            article_1,
           ]
         end
       end
@@ -98,14 +98,14 @@ RSpec.describe Rating::Extension, ':order_by_rating' do
         expect(Article.order_by_rating(:sum, :asc)).to eq [
           article_3,
           article_2,
-          article_1
+          article_1,
         ]
       end
 
       context 'with scope' do
         it 'works' do
           expect(Article.order_by_rating(:sum, :asc, scope: category)).to eq [
-            article_1
+            article_1,
           ]
         end
       end
@@ -116,14 +116,14 @@ RSpec.describe Rating::Extension, ':order_by_rating' do
         expect(Article.order_by_rating(:sum, :desc)).to eq [
           article_1,
           article_2,
-          article_3
+          article_3,
         ]
       end
 
       context 'with scope' do
         it 'works' do
           expect(Article.order_by_rating(:sum, :desc, scope: category)).to eq [
-            article_1
+            article_1,
           ]
         end
       end
@@ -142,7 +142,7 @@ RSpec.describe Rating::Extension, ':order_by_rating' do
       context 'with scope' do
         it 'works' do
           expect(Article.order_by_rating(:total, :asc, scope: category)).to eq [
-            article_1
+            article_1,
           ]
         end
       end
@@ -159,7 +159,7 @@ RSpec.describe Rating::Extension, ':order_by_rating' do
       context 'with scope' do
         it 'works' do
           expect(Article.order_by_rating(:total, :desc, scope: category)).to eq [
-            article_1
+            article_1,
           ]
         end
       end

spec/models/extension/rated_question_spec.rb

@@ -32,6 +32,7 @@ RSpec.describe Rating::Extension, ':rated?' do
     end
   end
 
+  if ENV['CONFIG_ENABLED_WITH_EXTRA_SCOPES'] == 'true'
     context 'with extra scopes' do
       before { author.rate resource, 1, extra_scopes: { scope_1: 'scope_1' } }
 
@@ -42,5 +43,6 @@ RSpec.describe Rating::Extension, ':rated?' do
       context 'when has rate for the given resource with given extra scopes' do
         specify { expect(author.rated?(resource, extra_scopes: { scope_1: 'scope_1' })).to eq true }
       end
-  end if ENV['CONFIG_ENABLED_WITH_EXTRA_SCOPES'] == 'true'
+    end
+  end
 end

spec/models/extension/rated_spec.rb

@@ -38,11 +38,13 @@ RSpec.describe Rating::Extension, ':rated' do
     end
   end
 
+  if ENV['CONFIG_ENABLED_WITH_EXTRA_SCOPES'] == 'true'
     context 'with extra scopes' do
       let!(:extra_scopes_rate) { author_1.rate article_1, 1, extra_scopes: { scope_1: 'scope_1' } }
 
       it 'returns records considering the extra scopes' do
         expect(author_1.rated(extra_scopes: { scope_1: 'scope_1' })).to eq [extra_scopes_rate]
       end
-  end if ENV['CONFIG_ENABLED_WITH_EXTRA_SCOPES'] == 'true'
+    end
+  end
 end

spec/models/extension/rates_spec.rb

@@ -38,11 +38,13 @@ RSpec.describe Rating::Extension, ':rates' do
     end
   end
 
+  if ENV['CONFIG_ENABLED_WITH_EXTRA_SCOPES'] == 'true'
     context 'with extra scopes' do
       let!(:extra_scopes_rate) { author_1.rate article_1, 1, extra_scopes: { scope_1: 'scope_1' } }
 
       it 'returns records considering the extra scopes' do
         expect(article_1.rates(extra_scopes: { scope_1: 'scope_1' })).to eq [extra_scopes_rate]
       end
-  end if ENV['CONFIG_ENABLED_WITH_EXTRA_SCOPES'] == 'true'
+    end
+  end
 end

spec/models/rate/create_spec.rb

@@ -194,6 +194,7 @@ RSpec.describe Rating::Rate, ':create' do
     end
   end
 
+  if ENV['CONFIG_ENABLED_WITH_EXTRA_SCOPES'] == 'true'
     context 'with extra scopes' do
       let!(:category) { create :category }
 
@@ -358,5 +359,6 @@ RSpec.describe Rating::Rate, ':create' do
           expect(rating.total).to     eq 2
         end
       end
-  end if ENV['CONFIG_ENABLED_WITH_EXTRA_SCOPES'] == 'true'
+    end
+  end
 end

spec/models/rate/rate_for_spec.rb

@@ -51,6 +51,7 @@ RSpec.describe Rating::Rate, ':rate_for' do
     end
   end
 
+  if ENV['CONFIG_ENABLED_WITH_EXTRA_SCOPES'] == 'true'
     context 'with extra scopes' do
       let!(:category) { create :category }
 
@@ -101,5 +102,6 @@ RSpec.describe Rating::Rate, ':rate_for' do
           expect(result).to eq nil
         end
       end
-  end if ENV['CONFIG_ENABLED_WITH_EXTRA_SCOPES'] == 'true'
+    end
+  end
 end

spec/models/rate_spec.rb

@@ -16,7 +16,7 @@ RSpec.describe Rating::Rate do
   it { is_expected.to validate_presence_of :value }
 
   it do
-    is_expected.to validate_numericality_of(:value).is_less_than_or_equal_to(100).is_less_than_or_equal_to 100
+    expect(subject).to validate_numericality_of(:value).is_less_than_or_equal_to(100).is_less_than_or_equal_to 100
   end
 
   it do