From 88d15ff40898d06fb3cab7dc51f4ee0d03d7872f Mon Sep 17 00:00:00 2001 From: Washington Botelho Date: Wed, 18 May 2022 11:26:52 -0300 Subject: [PATCH] spec: uses case conditional --- spec/models/rating/averager_data_spec.rb | 5 +++-- spec/models/rating/data_spec.rb | 5 +++-- spec/models/rating/update_rating_spec.rb | 5 +++-- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/spec/models/rating/averager_data_spec.rb b/spec/models/rating/averager_data_spec.rb index 1e7ca27..b3e7686 100644 --- a/spec/models/rating/averager_data_spec.rb +++ b/spec/models/rating/averager_data_spec.rb @@ -13,9 +13,10 @@ RSpec.describe Rating::Rating, ':averager_data' do end it 'returns the average of number of records for the given resource type' do - if ENV.fetch('DB') == 'mysql' + case ENV.fetch('DB') + when 'mysql' expect(result.count_avg).to eq(BigDecimal('1.333333333333333333')) - elsif ENV.fetch('DB') == 'postgres' + when 'postgres' expect(result.count_avg).to eq(BigDecimal('1.3333333333333333')) else raise('DB env missing!') diff --git a/spec/models/rating/data_spec.rb b/spec/models/rating/data_spec.rb index adfa826..1453054 100644 --- a/spec/models/rating/data_spec.rb +++ b/spec/models/rating/data_spec.rb @@ -21,9 +21,10 @@ RSpec.describe Rating::Rating, ':data' do end it 'returns the estimate for a resource' do - if ENV.fetch('DB') == 'mysql' + case ENV.fetch('DB') + when 'mysql' expect(result[:estimate]).to eq(BigDecimal('42.5000000000000000012000000505')) - elsif ENV.fetch('DB') == 'postgres' + when 'postgres' expect(result[:estimate]).to eq(BigDecimal('42.5000000000000001200000000000000012505')) else raise('DB env missing!') diff --git a/spec/models/rating/update_rating_spec.rb b/spec/models/rating/update_rating_spec.rb index 0afddca..863cf44 100644 --- a/spec/models/rating/update_rating_spec.rb +++ b/spec/models/rating/update_rating_spec.rb @@ -9,10 +9,11 @@ RSpec.describe Rating::Rating, ':update_rating' do it 'updates the rating data of the given resource' do record = described_class.find_by(resource: article_1) - if ENV.fetch('DB') == 'mysql' + case ENV.fetch('DB') + when 'mysql' expect(record.average).to eq(BigDecimal('50.5')) expect(record.estimate).to eq(BigDecimal('42.5')) - elsif ENV.fetch('DB') == 'postgres' + when 'postgres' expect(record.average).to eq(BigDecimal('50.5')) expect(record.estimate).to eq(BigDecimal('42.5000000000000001')) else